-
-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invalidate gem name using levenshtein distance for gems with ten million downloads #2037
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
require "rubygems/text" | ||
|
||
class GemTypo | ||
attr_reader :protected_gem | ||
|
||
include Gem::Text | ||
|
||
DOWNLOADS_THRESHOLD = 10_000_000 | ||
SIZE_THRESHOLD = 4 | ||
|
||
def initialize(rubygem_name) | ||
@rubygem_name = rubygem_name.downcase | ||
@distance_threshold = distance_threshold | ||
end | ||
|
||
def protected_typo? | ||
return false if @rubygem_name.size < GemTypo::SIZE_THRESHOLD | ||
|
||
protected_gems.each do |protected_gem| | ||
distance = levenshtein_distance(@rubygem_name, protected_gem) | ||
if distance <= @distance_threshold | ||
@protected_gem = protected_gem | ||
return true | ||
end | ||
end | ||
|
||
false | ||
end | ||
|
||
private | ||
|
||
def distance_threshold | ||
@rubygem_name.size == GemTypo::SIZE_THRESHOLD ? 1 : 2 | ||
end | ||
|
||
def protected_gems | ||
Rubygem.joins(:gem_download) | ||
.where("gem_downloads.count > ?", GemTypo::DOWNLOADS_THRESHOLD) | ||
.where.not(name: @rubygem_name) | ||
.pluck(:name) | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
require "test_helper" | ||
|
||
class GemTypoTest < ActiveSupport::TestCase | ||
context "with above downloads threshold gem" do | ||
setup do | ||
above_downloads_thres = GemTypo::DOWNLOADS_THRESHOLD + 1 | ||
create(:rubygem, name: "four", downloads: above_downloads_thres) | ||
end | ||
|
||
should "return false for exact match" do | ||
gem_typo = GemTypo.new("four") | ||
assert_equal false, gem_typo.protected_typo? | ||
end | ||
|
||
should "return false for gem name size below protected threshold" do | ||
gem_typo = GemTypo.new("fou") | ||
assert_equal false, gem_typo.protected_typo? | ||
end | ||
|
||
context "size equals protected threshold" do | ||
should "return true for one character distance" do | ||
gem_typo = GemTypo.new("fous") | ||
assert_equal true, gem_typo.protected_typo? | ||
end | ||
|
||
should "return false for two character distance" do | ||
gem_typo = GemTypo.new("foss") | ||
assert_equal false, gem_typo.protected_typo? | ||
end | ||
end | ||
|
||
context "size above protected threshold" do | ||
should "return true for two character distance" do | ||
gem_typo = GemTypo.new("fourss") | ||
assert_equal true, gem_typo.protected_typo? | ||
end | ||
|
||
should "return false for three characher distance" do | ||
gem_typo = GemTypo.new("foursss") | ||
assert_equal false, gem_typo.protected_typo? | ||
end | ||
end | ||
end | ||
end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about to "memoize" this to not execute same call on every iteration?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved it to the initializer.