Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalidate gem name using levenshtein distance for gems with ten million downloads #2037

Merged
merged 3 commits into from
Jul 8, 2019
Merged

Invalidate gem name using levenshtein distance for gems with ten million downloads #2037

merged 3 commits into from
Jul 8, 2019

Commits on Jun 13, 2019

  1. Add prototype model for GemTypo

    @sonalkr132
    Jonathan Claudius authored and sonalkr132 committed Jun 13, 2019
    Configuration menu
    Copy the full SHA
    9563103 View commit details
    Browse the repository at this point in the history

  2. Add protected_gem_typo_protection to rubygem validation

    @sonalkr132
    Jonathan Claudius authored and sonalkr132 committed Jun 13, 2019
    Configuration menu
    Copy the full SHA
    f667870 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2019

  1. Update gem typo logic and tests 

    Use downloads count as threshold instead of static list.
Limit validation to new gems.
Update distance threshold as mentioned in segiddins PR.

Existing gem we may consider blocking:
https://gist.github.com/sonalkr132/af05b030af793ce17a69245152d5aa5f
total: 4859 (2.98%)
    @sonalkr132
    sonalkr132 committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    5cd2749 View commit details
    Browse the repository at this point in the history