Cleanup factories and annotate them, drop partner users table #4536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmyli97
force-pushed
the
cleanup-annotate-factories
branch
4 times, most recently
from
e53d10f
to
f431a68
Compare
* Commit [838d511](rubyforgood@838d511) merged partner users into user table, this table can be dropped
jimmyli97
force-pushed
the
cleanup-annotate-factories
branch
from
f431a68
to
1d686be
Compare
jimmyli97
changed the title
dorner
requested changes
Jul 19, 2024
spec/factories/users.rb
Outdated
| @@ -51,6 +51,22 @@ | |||
| end | |||
| end | |||
|
|
|||
| factory :partners_user do | |||
There was a problem hiding this comment.
There were two identical factories, one called :partner_user defined in factories/partner_user.rb and one called :partners_user defined in factories/partners/user.rb
The codebase used both so I just did a coin flip and picked one to rename all of them to
dorner
requested changes
Jul 26, 2024
dorner
approved these changes
Aug 1, 2024
|
Nice, thanks! |
|
@jimmyli97: Your PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Clean up factories and annotate missing annotations
Type of change
How Has This Been Tested?
Passes test suite