4438 - Button Remain Activated After Selecting the Storage #4485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Naraveni
force-pushed
the
4438-ACTIVATE-ADD-ANOTHER-ITEM-AFTER-ERROR
branch
3 times, most recently
from
947a85e
to
e7f99ca
Compare
Naraveni
force-pushed
the
4438-ACTIVATE-ADD-ANOTHER-ITEM-AFTER-ERROR
branch
from
e7f99ca
to
da2b1ac
Compare
|
I have added test in distrbution and transfers system specs files as the changes I made are in js file which is related to distributions and transfers as the file name suggests. |
Naraveni
force-pushed
the
4438-ACTIVATE-ADD-ANOTHER-ITEM-AFTER-ERROR
branch
from
da2b1ac
to
85e004a
Compare
|
Functionality checks out. Over to @dorner for a technical pass |
dorner
requested changes
Jul 4, 2024
Naraveni
force-pushed
the
4438-ACTIVATE-ADD-ANOTHER-ITEM-AFTER-ERROR
branch
2 times, most recently
from
0f4ca3e
to
0649768
Compare
Naraveni
force-pushed
the
4438-ACTIVATE-ADD-ANOTHER-ITEM-AFTER-ERROR
branch
from
0649768
to
24a6d0f
Compare
|
And also the error message in transfers creation page was coming wrong ias the |
dorner
approved these changes
Jul 14, 2024
|
@Naraveni: Your PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4438
Description
Add Item button was getting de-activated if storage location is selected after first attempt of submitting form without selecting anything.
Include anything else we should know about. -->
Type of change