-
-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolves #3829 Improve codespaces debugging #4482
Resolves #3829 Improve codespaces debugging #4482
Conversation
CONTRIBUTING.md
Outdated
3. Run `bin/start` and visit the URL that pops in VSCode up to see the human essentials page | ||
4. Login as a sample user with the default [credentials](#credentials). | ||
3. Run `bin/start`. | ||
4. Right click on port 3000, set the port visibility to Public, and visit the URL that pops in VSCode up to see the human essentials page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interestingly, I've never had to do this step and was able to visit the URL without issue. Is this an optional step maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried again today and now the private port is working after a workaround so I think it is a bug in the VSCode Codespaces extension. Yesterday I tried to view the app at 127.0.0.1:3000 after port forwarding with visibility set to private and couldn't figure out why it wasn't working, I just got "ERR_EMPTY_RESPONSE". The server was up and running and I could curl to it just fine in the Codespace terminal, so I really couldn't figure out what was wrong. There was another contributor in Slack who ran into this issue also.
I removed the doc about public ports in commit 377cf8e
f4d30bd
to
84cf1e8
Compare
84cf1e8
to
377cf8e
Compare
* apt-get is best practice for scripts, see this [link](https://askubuntu.com/a/990838/1817536) * DEBIAN_FRONTEND noninteractive is best practice for Docker setup, see this [link](https://askubuntu.com/a/1430072/1817536)
* Can now run Chrome in NOT_HEADLESS=true and view tests in browser on Codespaces
879be46
to
1d4a0df
Compare
1d4a0df
to
92217c8
Compare
1116a39
to
3dfb6ea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works. Still takes a long time to start, and I didn't verify the VNC-browser bit. I think I liked it a bit more when the ports popped up instead of me needing to go click them, but I'll merge this in for the other improvements and we'll wait for general feedback. Thank you!
Looks like speeding up the container build is possible with a Github action prebuilding and pushing to ghcr.io, which is free storage for public repos, following this guide (https://containers.dev/guide/prebuild), I might be able to look into it when I have a chance (previous comment before edit) |
@jimmyli97: Your PR |
Fix #3829
Description
Motivation
I think it's safe to close #3829 with these fixes because I've been doing all my development in codespaces with this setup recently and it's working great.
Dependencies
gem
"debug", ">= 1.0.0"Type of change
How Has This Been Tested?
NOT_HEADLESS=true bundle exec rspec spec/system/partner_system_spec.rb
running in Codespaces is visible over noVNC on localhost:6080Screenshots