Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoscrolling when adding new items in donations/distributions/purchases/partner requests #4450

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

jp524
Copy link
Contributor

@jp524 jp524 commented Jun 13, 2024

Resolves #4440.

Description

Per issue description, when adding a new item to a donation, distribution, purchase or partner request the screen would stay in place. The users would have to scroll down to see the new item added.

This change introduces a simple fix in the Stimulus controller that adds new items.

  • The "add an item" behaviour described above works on new distributions, purchases, and donations
  • This behaviour also works when editing distributions, purchases, and donations
  • Same thing for requests

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

I did some manual testing in my local development environment. Please refer to video recording below.

Screenshots

Before
https://github.com/rubyforgood/human-essentials/assets/85654561/a87c0fc3-412b-4ea6-acd9-aae89bc966fb

After
https://github.com/rubyforgood/human-essentials/assets/85654561/214360d3-0ced-4054-9ba8-ca0fb6b9f994

Copy link
Collaborator

@cielf cielf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes manual testing with flying colours -- including the requests. @dorner -- Is this something that we can/should have an automatic test for? I don't seem to have requested it in the criteria for completion.

@dorner
Copy link
Collaborator

dorner commented Jun 14, 2024

An automatic test for this would be much more trouble than it's worth. I'm fine as is!

@dorner dorner merged commit 12423b9 into rubyforgood:main Jun 14, 2024
19 checks passed
Copy link
Contributor

@jp524: Your PR Autoscrolling when adding new items in donations/distributions/purchases/partner requests is part of today's Human Essentials production release: 2024.06.16.
Thank you very much for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autoscrolling when adding new items in donations/distributions/purchases
3 participants