Prevent changing storage location on itemizables if there has been an intervening audit of the items involved #4428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To be consistent with query in DistributionsController#edit action
|
passes manual testing. Asking @dorner for a technical review. |
dorner
approved these changes
Jun 14, 2024
|
Nice, thanks! |
|
@jp524: Your PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4304.
Description
I implemented the feature in
ItemizableUpdateServicesince donations, distributions and purchases all rely on this service to perform the update action.Type of change
How Has This Been Tested?
Added some tests in
spec/services/itemizable_update_service_spec.rb.Screenshots
Distribution
Donation
I noticed that when the donation update fails some select fields become empty and don't hold their initial value. I checked the staging server and the issue doesn't happen there, so I didn't look into it further.
Purchase
