Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding draft work on hotwire concept for implementing dependent dropdown #4420

Conversation

patelkrunal31
Copy link
Collaborator

Resolves #4398

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation update

How Has This Been Tested?

Screenshots

update_units() {
const item_id = this.element.value
console.log(item_id)
post(`/items/${item_id}/request_units`, {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be a get instead of a post?

@awwaiid
Copy link
Collaborator

awwaiid commented Jul 7, 2024

Hi @patelkrunal31 -- can you remind me what the status of this is and if you are actively working on it? IIRC I think we decided to close this and try another approach, but I can't remember.

@awwaiid
Copy link
Collaborator

awwaiid commented Aug 4, 2024

Thanks for this reference work. The version we'll merge is over at #4510, so I'm closing this attempt.

@awwaiid awwaiid closed this Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PACKS] #3 Allowing the selection of custom request units in partner request
2 participants