Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eagerly de-duplicating items when submitting request #4414

Merged
merged 11 commits into from
Jun 8, 2024
Merged

Eagerly de-duplicating items when submitting request #4414

merged 11 commits into from
Jun 8, 2024

Commits on Jun 1, 2024

  1. Eagerly de-duplicating items when submitting request

    @patelkrunal31
    patelkrunal31 committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    1a5aeea View commit details
    Browse the repository at this point in the history

  2. Adding validation on Request model to have unique request for item

    @patelkrunal31
    patelkrunal31 committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    d181cee View commit details
    Browse the repository at this point in the history

  3. Since we are no longer storing duplicate items per request, removing … 

    …this logic

https://github.com/rubyforgood/human-essentials/pull/3437/files
    @patelkrunal31
    patelkrunal31 committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    6e44bce View commit details
    Browse the repository at this point in the history

  4. Removing the need to have a test for duplicate items in the request

    @patelkrunal31
    patelkrunal31 committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    4b5e42f View commit details
    Browse the repository at this point in the history

  5. squashme! tweak child merge logic and post disclaimer

    @scooter-dangle @patelkrunal31
    scooter-dangle authored and patelkrunal31 committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    e206bd6 View commit details
    Browse the repository at this point in the history

  6. Testing the merging logic for duplicate child request which shouldn't… 

    … occur in production
    @patelkrunal31
    patelkrunal31 committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    789d9af View commit details
    Browse the repository at this point in the history

  7. squashme! fix operator precedence of child merge

    @scooter-dangle @patelkrunal31
    scooter-dangle authored and patelkrunal31 committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    67e45eb View commit details
    Browse the repository at this point in the history

  8. Adding a documentation on the fetch_items method

    @patelkrunal31
    patelkrunal31 committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    0b88184 View commit details
    Browse the repository at this point in the history

  9. Adding validation on item_reqests instead of request_items

    @patelkrunal31
    patelkrunal31 committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    1503829 View commit details
    Browse the repository at this point in the history

  10. Removing the refactor on request mailer to de-dupe

    @patelkrunal31
    patelkrunal31 committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    a72d9c0 View commit details
    Browse the repository at this point in the history

  11. squashme! don't create dup'd items when seeding requests

    @scooter-dangle
    scooter-dangle committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    44cb8f2 View commit details
    Browse the repository at this point in the history