Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#3910 Auto-thanking has bugs #3914

Merged
merged 2 commits into from
Oct 20, 2023
Merged

#3910 Auto-thanking has bugs #3914

merged 2 commits into from
Oct 20, 2023

Conversation

chriskarlin
Copy link
Contributor

@chriskarlin chriskarlin commented Oct 17, 2023 •
edited
Loading

Resolves #3910

Description

Updated GHA chriskarlin/github-release-commenter used in this project with its newest version that contains:

  • GHA input to skip commenting in linked events (Issues)
  • code guaranteeing each PR only gets commented on once

(PR that updated the Action)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Tested in my own project via: create Issue, fix via (and link) PR, create release -> observe comments added

Screenshots

PR

Screenshot 2023-10-17 at 8 52 04 AM

Issue

Screenshot 2023-10-17 at 8 51 57 AM

@chriskarlin chriskarlin mentioned this pull request Oct 17, 2023
Closed
2 tasks
@dorner dorner merged commit 547afa5 into rubyforgood:main Oct 20, 2023
11 checks passed
@dorner
Copy link
Collaborator

dorner commented Oct 20, 2023

Thanks so much!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2023

@chriskarlin: Your PR/Issue #3910 Auto-thanking has bugs is part of today's Human Essentials production release: 2023.11.05.
Thank you very much for your contribution!

@chriskarlin chriskarlin deleted the 3910-fix-auto-thanker-has-bugs branch December 24, 2023 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dorner dorner dorner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Auto-thanking has bugs
2 participants
@chriskarlin @dorner