Change checkboxes to radio buttons #3824
Conversation
| } | ||
|
|
||
| .form-yesno > div > div > label { |
There was a problem hiding this comment.
These kinds of rules are pretty brittle. Can we add some classes or IDs here?
There was a problem hiding this comment.
I was able to rewrite these rules to use classes.
spec/models/partners/profile_spec.rb
Outdated
| @@ -215,4 +215,19 @@ | |||
| describe "versioning" do | |||
| it { is_expected.to be_versioned } | |||
| end | |||
|
|
|||
| describe "default values" do | |||
There was a problem hiding this comment.
Not sure this needs its own test. You're basically asserting the default database values.
| @@ -0,0 +1,92 @@ | |||
| RSpec.describe "Partners profile radio buttons behaviour", type: :system, js: true do | |||
There was a problem hiding this comment.
This can be a request spec. System specs use a full browser and are only needed when testing interactions.
There was a problem hiding this comment.
I removed the system spec and re-implemented some of these tests as request spec.
|
Also, please fix the lint issues! |
mdphillips375
force-pushed
the
3804-boolean-to-radio
branch
from
c475fa5
to
0226248
Compare
|
Thanks for the contribution! FYI, for next time please do not force push branches that have active pull request conversations, as it becomes really hard to find the previous comments. |
Resolves #3804
Description
List any dependencies that are required for this change. (gems, js libraries, etc.)
No new dependencies
Include anything else we should know about. -->
Type of change
How Has This Been Tested?
Screenshots
Before:
Edit:
Show:
After:
Edit:
Show: