Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3726 Thank everyone when the release goes out automagically #3807

Conversation

chriskarlin
Copy link
Contributor

@chriskarlin chriskarlin commented Jul 30, 2023

Resolves #3726

Description

Added github action workflow file with a job that will be run on release/publish and comment on each pull request, that is part of the release, with a thank you note.
-> using my own fork of the github action since my PR to add author and title template var was not getting looked at
-> Known limitation: when PRs are linked to issue via linking by keywords, my forked action will not be able to pull author+title

Type of change

  • New feature (non-breaking change which adds functionality)
    -> Github Action

How Has This Been Tested?

Tested the workflow within a private repository of mine through creation of issues -> pull request -> releases

Screenshots

See comments below

Copy link
Collaborator

@dorner dorner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chriskarlin looks like the {author} part doesn't work, from the screenshot.

@cielf do we need the actual author name in the comment?

@chriskarlin
Copy link
Contributor Author

@dorner yes, sorry I just put it there as a placeholder for now, I should have mentioned that. Haven’t gotten around looking into adding it to the actual action yet, might find some time tomorrow though!

@cielf
Copy link
Collaborator

cielf commented Aug 4, 2023

@dorner, @chriskarlin It's definitely a plus if it's there -- and by author name, I mean author_id -- they'll get a more in-your-face notification if it's there, right?

@chriskarlin
Copy link
Contributor Author

Got a WIP PR for adding the author and title to the GHA here. Currently still not fully working, as I was getting permission issues "Failed to load title\" data-id=\"1885795064\" data-permission-text=\"Title is private\". Will be taking another look this afternoon

@chriskarlin
Copy link
Contributor Author

chriskarlin commented Sep 8, 2023

Made some progress with the PR:
Screenshot 2023-09-07 at 7 30 55 PM

Screenshot 2023-09-07 at 7 30 36 PM

Only thing thats not working yet, is getting the author and title of Issues through linking using Closes keyword, as we the action doesn't pull any info for those issue at all (find issue through regex).

Screenshot 2023-09-08 at 8 22 29 AM

@chriskarlin chriskarlin force-pushed the 3726-automatic-release-contibution-notifier branch from 842a628 to 1be7d77 Compare September 15, 2023 20:23
@chriskarlin chriskarlin force-pushed the 3726-automatic-release-contibution-notifier branch from 1be7d77 to bc6cf9a Compare October 9, 2023 17:49
@chriskarlin
Copy link
Contributor Author

After waiting many moons, it seems like my PR to add author and title to the GHA github-release-commenter is not getting merged/looked at (repo inactive). Talking to @dorner we decided to use my fork instead for now.

Alternatively, the original GHA could be forked by rubyforgood and the update pushed there instead

@chriskarlin chriskarlin marked this pull request as ready for review October 9, 2023 17:59
@chriskarlin chriskarlin changed the title [WIP] #3726 Thank everyone when the release goes out automagically #3726 Thank everyone when the release goes out automagically Oct 9, 2023
@dorner dorner merged commit 76988be into rubyforgood:main Oct 12, 2023
11 checks passed
@dorner
Copy link
Collaborator

dorner commented Oct 12, 2023

Thanks! Let's give this a shot!

@chriskarlin chriskarlin deleted the 3726-automatic-release-contibution-notifier branch October 12, 2023 00:55
@github-actions
Copy link
Contributor

@chriskarlin: Your PR/Issue #3726 Thank everyone when the release goes out automagically is part of today's Human Essentials production release: 2023.10.15.
Thank you very much for your contribution!

@dorner dorner mentioned this pull request Oct 15, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Thank everyone when the release goes out automagically.
3 participants