-
-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#3726 Thank everyone when the release goes out automagically #3807
#3726 Thank everyone when the release goes out automagically #3807
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chriskarlin looks like the {author} part doesn't work, from the screenshot.
@cielf do we need the actual author name in the comment?
@dorner yes, sorry I just put it there as a placeholder for now, I should have mentioned that. Haven’t gotten around looking into adding it to the actual action yet, might find some time tomorrow though! |
@dorner, @chriskarlin It's definitely a plus if it's there -- and by author name, I mean author_id -- they'll get a more in-your-face notification if it's there, right? |
Got a WIP PR for adding the |
Made some progress with the PR: Only thing thats not working yet, is getting the author and title of Issues through linking using |
842a628
to
1be7d77
Compare
1be7d77
to
bc6cf9a
Compare
After waiting many moons, it seems like my PR to add author and title to the GHA github-release-commenter is not getting merged/looked at (repo inactive). Talking to @dorner we decided to use my fork instead for now. Alternatively, the original GHA could be forked by rubyforgood and the update pushed there instead |
Thanks! Let's give this a shot! |
@chriskarlin: Your PR/Issue |
Resolves #3726
Description
Added github action workflow file with a job that will be run on
release/publish
and comment on each pull request, that is part of the release, with a thank you note.-> using my own fork of the github action since my PR to add author and title template var was not getting looked at
-> Known limitation: when PRs are linked to issue via linking by keywords, my forked action will not be able to pull author+title
Type of change
-> Github Action
How Has This Been Tested?
Tested the workflow within a private repository of mine through creation of issues -> pull request -> releases
Screenshots
See comments below