Move FullStory script after importmaps #3790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awwaiid
previously requested changes
Jul 29, 2023
Running Javascript before the importmap seems to break Firefox's
ability to load external modules.
Notes:
1. Minimizing the fullstory_script code to
`<script>(function(){})</script>` still failed.
2. The import map works enough to load our application.js but fails to
load jQuery (the first import in application.js).
fixes #3767
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3767 (on modified dev)
Description
Running Javascript before the importmap seems to break Firefox's ability to load external modules.
Notes:
<script>(function(){})</script>still failed.Type of change
How Has This Been Tested?
if Rails.env.production?from thefullstory_scriptcalls onmain.Uncaught TypeError: The specifier “jquery” was a bare specifier, but was not remapped to anything. Relative module specifiers must start with “./”, “../” or “/”.Can also test by clicking on
<collapsed sections in sidebar or any icon in the top bar (hamburger, calendar, or bell).