Added a way to list the product drive participants for a product drive #3762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Scott Steele <scottlsteele@gmail.com>
There was a problem hiding this comment.
Left a couple comments, aside from which this looks good. Being a non Rails expert myself, maybe @awwaiid could give a quick skim for the Rails-idiomaticity?
Co-authored-by: Scott Steele <scottlsteele@gmail.com>
Co-authored-by: Scott Steele <scottlsteele@gmail.com>
I have addressed your feedback and it is ready for rereview. |
dorner
requested changes
Aug 11, 2023
| @@ -100,3 +100,48 @@ | |||
| </div> | |||
| </div> | |||
| </section> | |||
|
|
|||
| <section class="content"> | |||
There was a problem hiding this comment.
Can we add a check in the request spec for this to see that the right information is being displayed? If there isn't a request spec, we should create one :)
There was a problem hiding this comment.
I have added a test in my latest commit.
dorner
approved these changes
Aug 18, 2023
|
Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3668
Description
Type of change
How Has This Been Tested?
Screenshots