Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Mismatch between overall manufacturer numbers and individual manufacturer donation numbers #4544

Closed
3 tasks
cielf opened this issue Jul 21, 2024 · 4 comments · Fixed by #4558
Closed
3 tasks

Comments

@cielf
Copy link
Collaborator

cielf commented Jul 21, 2024

Summary

The manufacturer donations report individual values are not being constrained by the timeframe selected. They should be.

Details

This report is found under "Reports | Donations-Manufacturer" in the left hand menu.

The manufacturer donations report is showing the total manufacture donations according to the selected timeframe, but the top manufacturers are not showing according to the selected timeframe.

Example, from January 9, 2024
Image

Some things to consider:
1/ Are the top manufacturers being selected and ranked according to the timeframe?
2/ The values shown for each of those manufacturers should be constrained by the timeframe.

Criteria for completion

  • The top manufacturers are selected and ranked according to the activity during the timeframe
  • The values shown for each manufacturer in that list are the donations during the selected timeframe
  • Tests to demonstrate the above.
@cielf cielf added Help Wanted Groomed + open to all! Difficulty—Beginner labels Jul 21, 2024
@awwaiid awwaiid modified the milestone: Tasks 2024 Jul 28, 2024
@guswhitten
Copy link
Contributor

@cielf I can take on this issue

@cielf
Copy link
Collaborator Author

cielf commented Jul 29, 2024

You've got it!

@github-actions GitHub Actions bot removed the Help Wanted Groomed + open to all! label Jul 29, 2024
guswhitten added a commit to guswhitten/human-essentials that referenced this issue Jul 30, 2024
Copy link
Contributor

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

Copy link
Contributor

GitHub Actions bot commented Sep 5, 2024

Automatically unassigned after 7 days of inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants