Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to search by user email to superuser user view #3728

Closed
3 tasks
cielf opened this issue Jul 9, 2023 · 6 comments · Fixed by #3811
Closed
3 tasks

Add ability to search by user email to superuser user view #3728

cielf opened this issue Jul 9, 2023 · 6 comments · Fixed by #3811
Assignees
Labels

Comments

@cielf
Copy link
Collaborator

cielf commented Jul 9, 2023

Summary

Add the ability to search by user email to the superuser user view

Why?

Most of the partners are "Name not provided"s . We can only search by name. This means we really can't search at all.

Details

Recreation

sign in as superadmin@example.com
Users | All Users

This needs a "search by email" field, which should work in the same way as the "search by name" field currently does.

Criteria for completion

  • "Search by email" on superuser's all users view exists and works
  • "Search by name" still works
  • Tests to support the above
@cielf cielf added Help Wanted Groomed + open to all! Difficulty—Beginner labels Jul 9, 2023
@Kernapillar
Copy link
Contributor

Hi, can I work on this?

@dorner
Copy link
Collaborator

dorner commented Jul 9, 2023

Go for it!

@Kernapillar
Copy link
Contributor

is there a preference between adding a second search bar that only searches by email vs adding a toggle or dropdown to select the search criteria?

@cielf
Copy link
Collaborator Author

cielf commented Jul 18, 2023

Our usual pattern is to have fields for each of the things you can filter by, and a single button for the search. (If you sign in as org_admin@example.com, you can see that on the dashboard, for instance)

Kernapillar added a commit to Kernapillar/human-essentials that referenced this issue Aug 3, 2023
Kernapillar added a commit to Kernapillar/human-essentials that referenced this issue Aug 4, 2023
Kernapillar added a commit to Kernapillar/human-essentials that referenced this issue Aug 5, 2023
Kernapillar added a commit to Kernapillar/human-essentials that referenced this issue Aug 10, 2023
Kernapillar added a commit to Kernapillar/human-essentials that referenced this issue Aug 14, 2023
@github-actions
Copy link
Contributor

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

@github-actions github-actions bot added the stale label Aug 18, 2023
@Kernapillar
Copy link
Contributor

Commenting for the actions bot! The linked PR should be good to go, if anyone is available to do another quick review pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants