Skip to content

Commit

Permalink
fix: remove mini_racer to prevent segfaults (and because we don't use…
Browse files Browse the repository at this point in the history
… it) (#4478)

* fix: downgrade mini_racer to prevent segfaults

Currently when I run `rails assets:precompile` the application
segfaults. This seems to be related to mini_racer.

The easiest solution is to downgrade to a version of mini_rancer without
these issues.

See rubyjs/mini_racer#300 for more info.

* fix: remove it instead
  • Loading branch information
elasticspoon committed Jul 3, 2024
1 parent 693c866 commit 3ca0ed9
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 7 deletions.
1 change: 0 additions & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,6 @@ gem "clockwork"
# These are gems that aren't used directly, only as dependencies for other gems.
# Technically they don't need to be in this Gemfile at all, but we are pinning them to
# specific versions for compatibility reasons.
gem "mini_racer", "~> 0.12.0"
gem "nokogiri", ">= 1.10.4"
gem "image_processing"
gem "sprockets", "~> 4.2.1"
Expand Down
6 changes: 0 additions & 6 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -336,9 +336,6 @@ GEM
childprocess (~> 5.0)
letter_opener (1.10.0)
launchy (>= 2.2, < 4)
libv8-node (21.7.2.0-arm64-darwin)
libv8-node (21.7.2.0-x86_64-darwin)
libv8-node (21.7.2.0-x86_64-linux)
lint_roller (1.1.0)
listen (3.9.0)
rb-fsevent (~> 0.10, >= 0.10.3)
Expand Down Expand Up @@ -367,8 +364,6 @@ GEM
method_source (1.1.0)
mini_magick (4.11.0)
mini_mime (1.1.5)
mini_racer (0.12.0)
libv8-node (~> 21.7.2.0)
minitest (5.24.0)
monetize (1.12.0)
money (~> 6.12)
Expand Down Expand Up @@ -747,7 +742,6 @@ DEPENDENCIES
lograge
magic_test
matrix
mini_racer (~> 0.12.0)
money-rails
newrelic_rpm
nokogiri (>= 1.10.4)
Expand Down

0 comments on commit 3ca0ed9

Please sign in to comment.