Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade to rails 7.2 #6028

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

elasticspoon
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code labels Sep 7, 2024
@elasticspoon elasticspoon force-pushed the feat/upgrade-to-rails-72 branch 5 times, most recently from f438051 to dd07321 Compare September 7, 2024 23:55
@elasticspoon elasticspoon force-pushed the feat/upgrade-to-rails-72 branch 2 times, most recently from 17d0614 to f214a08 Compare September 8, 2024 06:14
@github-actions github-actions bot added the erb label Sep 8, 2024
@elasticspoon elasticspoon force-pushed the feat/upgrade-to-rails-72 branch 5 times, most recently from 789c281 to 4c97056 Compare September 10, 2024 20:29
fix: deperecations
- swap enums to use symbol style calls instead of keyword calls
- ensure form_with(model:) is not called with nil

fix: remove old defaults

feat: fix json issues

prepend ActiveSupport to classes that use to_json to ensure we use
ActiveSupport implementation of to_json instead of Object to_json (which
is an alias for to_s)

fix: accessible concern

Some change in rails 7.2 made drawing of routes in an RSpec test not
play well with config.eager_load = true. Thus, in CI these tests would
fail.

Changed the way routes were dynamically added to fix.

fix: add dummy secret key for parallel CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file erb ruby Pull requests that update Ruby code Tests! 🎉💖👏
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant