Case contacts contact made default yes

[DariusPirvulescu]

What github issue is this PR for, if any?

Resolves #6016

What changed, and why?

This changes the default value for the contact_made column to true. This was done via a migration. Please let me know if that's alright or if we should do it via helpers and change the radio_button checked value.

I'm still learning and I am very much open to suggestions.

How is this tested? (please write tests!) 💖💪

One of the specs was testing if @case_contact.contact_made was blank/false. With this change, the case_contact column will be true so the test failed. I removed this attribute from the tests as with the new migration, it is not the case for it to be blank.

Screenshots please :)

Run your local server and take a screenshot of your work! Try to include the URL of the page as well as the contents of the page.

Feelings gif (optional)

What gif best describes your feeling working on this issue? https://giphy.com/
How to embed:
![alt text](https://media.giphy.com/media/1nP7ThJFes5pgXKUNf/giphy.gif)

[elasticspoon]

I think I would rather we do the change via that helper method that you pointed out.

The logic being, typically the data base schema essentially outlines the "axioms" or fundamental truth of the application (ex: a user can only belong to one organization, case contact must belong to a case).

In this case I would consider the default to be more of "business" logic. This is what the users want at the moment and they might just want it to change again in the future, we have no reason to tie ourselves to that decision. Thus, its better to do it in the ruby code and that helper looks like a great place for it.

[DariusPirvulescu]

Thanks for the help.
What if we create a CaseContact instance and set the contact_made: true?
This will remove the need for the set_contact_made_false helper and its tests.
(I pushed the commits for this)

Previously, the set_contact_made_false helper checked if case_contact.persisted?, but it always persisted as we created the instance beforehand.

Please let me know what you think of this solution :)

[elasticspoon]

Small bit of feedback but overall LGTM! Thanks!