Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index page redesign #864

Merged
merged 13 commits into from
Oct 15, 2021
Merged

Index page redesign #864

merged 13 commits into from
Oct 15, 2021

Conversation

rruiz85
Copy link
Contributor

@rruiz85 rruiz85 commented Oct 14, 2021

What this PR does:

  1. This PR is a redesign of the index page for Abalone Analytics.
  2. The navigation hamburger was adjusted to be positioned on the right side when on mobile and tablet view.
  3. The hero image was redesigned and more content was added to communicate about us better.
  4. Removed "More" drop down from the nav
  5. Made the links to contribute to Github repo and resources available on the index page when a user is logged in and logged out.
  6. The Cohorts, Animals, Encolsures, Locations links is now under the "Statistics" dropdown.
  7. The Log out and change password links is now under the "users" dropdown

Final Design -
index-redesign

@seanmarcia
Copy link
Member

Looks like there is a css conflict.

@CraigJZ
Copy link
Collaborator

CraigJZ commented Oct 14, 2021

Apologies for the delay!!

I think this design looks great!! We will need to rebase from main to resolve the merge conflict that Sean mentioned.

I'm getting a Sassc Syntax error when trying to view the changes locally. I'm trying to figure out if that is something on my end or something we will need to look at before merging.

ActionView::Template::Error (Error: Undefined variable: "$color-light".
        on line 6:10 of app/assets/stylesheets/home.scss
>>   color: $color-light;

@CraigJZ CraigJZ self-requested a review October 14, 2021 18:17
@CraigJZ
Copy link
Collaborator

CraigJZ commented Oct 15, 2021

Thanks for checking on the home.scss. I am no longer seeing an error locally.

This looks great. I really like the re-organized navigation structure. One question on that - would it be possible to change the "Users" nav item to be "User" since those items pertain to stuff a single user can do as opposed to the admin nav item for managing users?

I'm seeing an issue with a few of the buttons. Would you mind taking a look?

Screen Shot 2021-10-14 at 11 36 41 PM

Screen Shot 2021-10-14 at 11 36 32 PM

Screen Shot 2021-10-14 at 11 36 25 PM

The CI picked up a couple of failing specs for the homepage statistics. I think those specs are just looking for some of the old styles. Happy to help get those resolved, if you'd like.

I'll be available in the morning, if you have any questions or want me to take a look at anything. Thanks again for all the work on this.

@CraigJZ CraigJZ merged commit 235fd89 into rubyforgood:main Oct 15, 2021
@CraigJZ CraigJZ mentioned this pull request Oct 15, 2021
@mattwd7 mattwd7 mentioned this pull request Oct 18, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants