Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Math magicians: full website #5

Merged
merged 11 commits into from
Jul 19, 2023
Merged

Math magicians: full website #5

merged 11 commits into from
Jul 19, 2023

Conversation

rubydevi
Copy link
Owner

Description:
In this project, I have created a full website for the Math Magicians app, consisting of several pages and using the components I already created.

Changes Made:

  • Created a website consisting of 3 pages: Home, Calculator, and Quote.
  • The general layout matches the provided wireframes
  • Added my own styles to improve the look and feel.
  • Added a <Route> for every page.
  • Made sure that navigation links for all 3 routes are displayed on each page.
  • Used React Router to make the routes work.

Please review my PR, I'd really appreciate your feedback 😄

@rubydevi rubydevi self-assigned this Jul 19, 2023
Copy link

@mckent05 mckent05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rubydevi,

STATUS: APPROVED ✔️ ✔️

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations and well done! 🎉
approved

Highlights

  • All linter checks are passing ✔️ ✔️
  • Your PR is professional 👏 👏
  • You have done well creating a full website for your app 👏

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

src/App.js Show resolved Hide resolved
@rubydevi rubydevi merged commit 7950916 into dev Jul 19, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants