Math magicians: components #2
Conversation
There was a problem hiding this comment.
Hi @rubydevi ,
Congratulations on the good job done so far! 🤝
There are some issues that you still need to work on to go to the next project but you are almost there! 😄
Highlights ⚡ ⚡
- Good commit messages ✔
- Correct Git flow ✔️
- Descriptive PR body ✔️
Required Changes ♻️
Check the comments under the review.
- Kindly delete the following filesbecause they are considered boiler plate code
App.test.js, index.css, setupTest.js, ...& all others that are auto generated but not used in this PR 😺
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
There was a problem hiding this comment.
- It is a project requirement that Calculator component should have at least 1 child component. I suggest you create the button as a component and import & use it here 👍🏾
There was a problem hiding this comment.
- [OPTIONAL] I suggest that you give the calculator a definate size according to the project design. A fluid calculator witll be hard to style if the page has other components. 👍🏾
There was a problem hiding this comment.
Hi @rubydevi,
Status: Approved ✔️
Excellent job on making the changes requested by the previous code reviewer. Keep it up 👏
Your project is complete! There is nothing else to say other than... it's time to merge it 💪
Congratulations! 🎉
To highlight 🍾
- The calculator component has a child component. ✔️
- App runs ✔️
[Optional] suggestions:
- Nothing to mention.
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag @topeogunleye in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Description:
In this project, I have continued with the development of the Math Magicians app. I have developed a React component that will hold the core functionality: a calculator.
Changes Made:
components.Calculator.jsfile.Calculator.js, created a React component that matches the provided design.CSSandJSXto design theUIPlease review my code, your feedback is highly appreciated.