Ensure service is reset after scenario test failures #175
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in scenario_compiler.rb where
core.reset!
is not called when a test case fails. Due to this issue, one failing scenario can result in verbose failure messages that indicate irrelevant scenarios have also failed.It seems that scenario_compiler.rb itself currently does not have test cases. While I have not added any in this PR, I will give it a try if requested.
Reproduction procedure
scenario/a1.rb
with the following content.scenario/a2.rb
with the following content.rake test
.Expected Behavior
Only a1.rb fails.
Actual Behavior (prior to this PR)
a2.rb also fails, due to the code introduced by a1.rb.