Skip to content

Commit

Permalink
Test Reline::Face without mocking (#600)
Browse files Browse the repository at this point in the history
* Test Reline::Face without mocking

Because `test-unit-rr` is not a default gem, using it would break CRuby's
CI.

* Add ruby-core workflow
  • Loading branch information
st0012 committed Nov 6, 2023
1 parent fdc1d3b commit d2189ac
Show file tree
Hide file tree
Showing 4 changed files with 65 additions and 14 deletions.
59 changes: 59 additions & 0 deletions .github/workflows/ruby-core.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,59 @@
name: ruby-core

on:
pull_request:

push:
branches:
- master

concurrency:
group: ci-${{ github.ref }}-${{ github.workflow }}

permissions: # added using https://github.com/step-security/secure-workflows
contents: read

jobs:
ruby_core:
name: Reline under a ruby-core setup
runs-on: ubuntu-20.04
strategy:
fail-fast: false
timeout-minutes: 30
steps:
- name: Set up latest ruby head
uses: ruby/setup-ruby@250fcd6a742febb1123a77a841497ccaa8b9e939 # v1.152.0
with:
ruby-version: head
bundler: none
- name: Save latest buildable revision to environment
run: echo "REF=$(ruby -v | cut -d')' -f1 | cut -d' ' -f5)" >> $GITHUB_ENV
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v3.1.0
with:
repository: ruby/ruby
path: ruby/ruby
fetch-depth: 10
- name: Checkout the latest buildable revision
run: git switch -c ${{ env.REF }}
working-directory: ruby/ruby
- name: Install libraries
run: |
set -x
sudo apt-get update -q || :
sudo apt-get install --no-install-recommends -q -y build-essential libssl-dev libyaml-dev libreadline6-dev zlib1g-dev libncurses5-dev libffi-dev libgdbm-dev bison autoconf ruby
- name: Build Ruby
run: |
autoconf
./configure -C --disable-install-doc
make -j2
working-directory: ruby/ruby
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v3.1.0
with:
path: ruby/reline
- name: Sync tools
run: |
ruby tool/sync_default_gems.rb reline
working-directory: ruby/ruby
- name: Test Reline
run: make -j2 -s test-all TESTS="reline --no-retry"
working-directory: ruby/ruby
1 change: 0 additions & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,5 @@ end
gem 'bundler'
gem 'rake'
gem 'test-unit'
gem 'test-unit-rr'

gem 'racc'
1 change: 0 additions & 1 deletion test/reline/helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

require 'reline'
require 'test/unit'
require 'test/unit/rr'

begin
require 'rbconfig'
Expand Down
18 changes: 6 additions & 12 deletions test/reline/test_face.rb
Original file line number Diff line number Diff line change
Expand Up @@ -151,17 +151,6 @@ def setup
@config = Reline::Face.const_get(:Config).new(:my_config) { }
end

def test_the_order_of_define_values_should_be_preserved
any_instance_of(Reline::Face.const_get(:Config)) do |config|
mock(config).format_to_sgr(
[[:foreground, :blue], [:style, [:bold, :italicized]], [:background, :red]]
)
end
Reline::Face.config(:my_config) do |face|
face.define :default, foreground: :blue, style: [:bold, :italicized], background: :red
end
end

def test_rgb?
assert_equal true, @config.send(:rgb_expression?, "#FFFFFF")
end
Expand All @@ -171,11 +160,16 @@ def test_invalid_rgb?
assert_equal false, @config.send(:rgb_expression?, "#FFFFF")
end

def test_format_to_sgr
def test_format_to_sgr_preserves_order
assert_equal(
"#{RESET_SGR}\e[37;41;1;3m",
@config.send(:format_to_sgr, foreground: :white, background: :red, style: [:bold, :italicized])
)

assert_equal(
"#{RESET_SGR}\e[37;1;3;41m",
@config.send(:format_to_sgr, foreground: :white, style: [:bold, :italicized], background: :red)
)
end

def test_format_to_sgr_with_reset
Expand Down

0 comments on commit d2189ac

Please sign in to comment.