Introduce rubocop-on-rbs #1899
Merged
Introduce rubocop-on-rbs #1899
+55
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Applied followings - RBS/Layout/SpaceAroundOperators - RBS/Layout/OverloadIndentation - RBS/Layout/SpaceBeforeOverload - RBS/Layout/ExtraSpacing - RBS/Layout/SpaceAroundBraces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose to introduce rubocop-on-rbs.
This is a lint tool for RBS file.
This tool automates trivial indentation and style remarks during review.
Examples of remarks from RuboCop
Departments
This PR enables
RBS/LayoutandRBS/Lintdepartments.RBS/Layoutprovides feedback on indentation and spacing, which does not affect the semantics of RBS at all.RBS/Lintpoints out important issues such as syntax errors and unused type variables.See also all documentation.
https://github.com/ksss/rubocop-on-rbs/blob/main/docs/modules/ROOT/pages/cops.adoc
This introduction does not use
RBS/Stylecops.RBS/Stylewill be discussed and introduced one by one later.Notice
I'm not sure that running the RuboCop task on both
headand3.3in CI.Probably for the purpose of running rubycw with head.