Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Encoding::Converter #1585

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sampersand
Copy link
Contributor

@sampersand sampersand commented Oct 28, 2023

This updates Encoding::Converter.

More specifically, it:

  • Encoding::Converter::encoding: Removed (lives in builtin.rbs)
  • Moved constants within Encoding::Converter
  • {search_convpath,initialize}: Added flags variant, split apart newlines vs explicit newline arguments
  • ==: RHS is now untyped
  • {convert,insert_output,putback} now accepts implicit args
  • convpath no longer returns conversion_path (It's not [encoding,encoding] but [Encoding,Encoding])
  • last_error: Merged return types
  • primitive_convert: Now takes implicit int and strings, also added flags variant
  • replacement= now takes boolish
  • Added tests for the above

TODO: finalize tests

@sampersand sampersand force-pushed the swesterman/23-10-28/encoding_converter branch from 31418b7 to 1c40316 Compare February 8, 2024 03:40
@sampersand sampersand force-pushed the swesterman/23-10-28/encoding_converter branch from 63f8b15 to 6c7456a Compare February 8, 2024 03:49
@sampersand sampersand marked this pull request as ready for review February 8, 2024 03:49
@sampersand sampersand marked this pull request as draft February 8, 2024 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant