Make TypeNameResolver more compatible with Ruby #1373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soutaro
commented
Jul 13, 2023
| manager.build do |env| | ||
| resolver = Resolver::TypeNameResolver.new(env) | ||
|
|
||
| assert_nil resolver.resolve(type_name("Foo::Bar"), context: [[nil, TypeName("::Foo")], TypeName("::Foo::Foo")]) |
There was a problem hiding this comment.
It tried ::Foo::Foo::Foo::Bar, ::Foo::Foo::Bar, and ::Foo::Bar and resolved to ::Foo::Bar, but it was not how Ruby resolves constants.
With this PR, it tries only with the first component of given type name Foo as ::Foo::Foo::Foo and ::Foo::Foo, and resolves to ::Foo::Foo. Then it adds the tail part Bar as ::Foo::Foo::Bar, but it doesn't exist. So, it returns nil.
soutaro
force-pushed
the
type-name-resolver
branch
from
ad83d4c
to
4cfd7da
Compare
soutaro
added a commit
that referenced
this pull request
Jul 27, 2023
Make TypeNameResolver more compatible with Ruby
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.