Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve type signature for Kernel.exec #1368

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Improve type signature for Kernel.exec #1368

merged 1 commit into from
Jul 13, 2023

Conversation

camertron
Copy link
Contributor

According to the official Ruby documentation, Kernel.exec should have the same type signature as Kernel.spawn except for the return value.

@soutaro soutaro added this to the RBS 3.2 milestone Jul 13, 2023
soutaro
soutaro approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@soutaro soutaro added this pull request to the merge queue Jul 13, 2023
Merged via the queue into ruby:master with commit 89212fb Jul 13, 2023
31 checks passed
@camertron camertron deleted the exec branch July 13, 2023 17:05
@soutaro soutaro added the Released PRs already included in the released version label Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soutaro soutaro soutaro approved these changes

Assignees
No one assigned
Labels
Released PRs already included in the released version
Milestone
RBS 3.2
Development

Successfully merging this pull request may close these issues.
2 participants
@camertron @soutaro