Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ERB::Util and ERB::DefMethod signature #1074

Merged
merged 1 commit into from
Aug 4, 2022
Merged

Add ERB::Util and ERB::DefMethod signature #1074

merged 1 commit into from
Aug 4, 2022

Conversation

ksss
Copy link
Collaborator

@ksss ksss commented Jul 28, 2022

Add undefined module signature in ERB.

# define *methodname* as instance method of current module, using ERB object or
# eRuby file
#
def self.def_erb_method: (String methodname, (String | ERB) erb_or_fname) -> untyped
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is practically impossible to call it as an instance method of def_erb_method, so I just used self.

Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@soutaro soutaro merged commit ccec2a1 into ruby:master Aug 4, 2022
@ksss ksss deleted the erb branch August 5, 2022 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants