Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated lib/prism/translation/parser/rubocop.rb file #3023

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Remove deprecated lib/prism/translation/parser/rubocop.rb file #3023

merged 1 commit into from
Aug 29, 2024

Commits on Aug 29, 2024

  1. Remove deprecated lib/prism/translation/parser/rubocop.rb file 

    Follow up ruby#2558.

This PR removes deprecated lib/prism/translation/parser/rubocop.rb file.

The file was a workaround to allow setting `TargetRubyVersion: 80_82_73_83_77.xx` until Prism (`Prism::Translation::Parser`) is integrated into RuboCop.
RuboCop already supports Prism (`Prism::Translation::Parser`) as of rubocop/rubocop#12724.

It has been several months since the file was deprecated in ruby#2558.
And, yesterday, Prism 1.0.0 was released, but perhaps the file should have been removed before then.

Although this might be seen as incompatible with semver 1.0.0, I think there is no longer a reason to keep the file.
    @koic
    koic committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    646a102 View commit details
    Browse the repository at this point in the history