Rename constant pool fields to name or operator #1338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `constant_id` and `operator_id` are confusing. * See ruby#1296
eregon
commented
Aug 27, 2023
Comment on lines
469
to
470
| *params.keywords.reject(&:value).map { |param| param.name.chomp(":").to_sym }, | ||
| *params.keywords.select(&:value).map { |param| param.name.chomp(":").to_sym } |
There was a problem hiding this comment.
It'd be consistent if KeywordParameterNode#name returns the Symbol without this extra handling, but for that it should probably be added to the constant pool first (and the constant pool needs to support owned strings first, #1134).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
constant_idandoperator_idare confusing.