Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding kind for node[] fields where possible #2058

Closed
eregon opened this issue Dec 13, 2023 · 3 comments · Fixed by #2497
Closed

Adding kind for node[] fields where possible #2058

eregon opened this issue Dec 13, 2023 · 3 comments · Fixed by #2497
Assignees
@eregon
Labels
enhancement New feature or request
Milestone
Long-term

Comments

@eregon
Copy link
Member

eregon commented Dec 13, 2023

For at least some of the node[] we could give a kind and so that array's elements would have a proper type in documentation, Java code, etc.
Some example:

  • MatchWriteNode#targets, (I think) always LocalVariableTargetNode

Some counter example:

  • ParametersNode#requireds, not always RequiredParameterNode, can also be MultiTargetNode

In some cases it's not possible because multiple classes are possible, or a MissingNode is possible.
@eregon eregon added the enhancement New feature or request label Dec 13, 2023
@eregon eregon changed the title Adding kind for node[] fields Adding kind for node[] fields where possible Dec 13, 2023
@kddnewton kddnewton added this to the Ruby 3.4.0 milestone Dec 14, 2023
@kddnewton
Copy link
Collaborator

Yes I agree. I think we should also use this opportunity to expand the syntax to support a set of nodes for languages where a union makes sense.

@eregon
Copy link
Member Author

eregon commented Dec 14, 2023

Indeed, a union would be super helpful, even if it only ends up in documentation.
(Java doesn't have union types unfortunately)

@nixme nixme mentioned this issue Dec 19, 2023
Merged
@eregon
Copy link
Member Author

eregon commented Jan 9, 2024

Probably we can consider this done when #2101 (comment) is merged.

@kddnewton kddnewton modified the milestones: CRuby unblocked, Long-term Feb 14, 2024
eregon added a commit to eregon/yarp that referenced this issue Feb 25, 2024
@eregon
Give a kind to all node[] fields which can have one more specific tha…
23abcdd 
…n "any Node"

* Fixes ruby#2058
eregon added a commit to eregon/yarp that referenced this issue Feb 25, 2024
@eregon
Give a kind to all node[] fields which can have one more specific tha…
dc21a36 
…n "any Node"

* Fixes ruby#2058
@eregon eregon mentioned this issue Feb 25, 2024
Merged
@eregon eregon self-assigned this Feb 25, 2024
eregon added a commit to eregon/yarp that referenced this issue Feb 28, 2024
@eregon
Give a kind to all node[] fields which can have one more specific tha…
f3e3310 
…n "any Node"

* Fixes ruby#2058
matzbot pushed a commit to ruby/ruby that referenced this issue Feb 28, 2024
@eregon @matzbot
[ruby/prism] Give a kind to all node[] fields which can have one more…
ea2cb00 
… specific than "any Node"

* Fixes ruby/prism#2058

ruby/prism@f3e3310b5e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eregon eregon

Labels
enhancement New feature or request
Projects
None yet
Milestone
Long-term
Development

Successfully merging a pull request may close this issue.

Give a kind to all node[] fields and better types in Java-generated code eregon/yarp
2 participants
@eregon @kddnewton