Fix Location#end_column

ruby · Sep 6, 2023 · 00e4711 · 00e4711
1 parent 0a11ec5
commit 00e4711
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/lib/yarp.rb b/lib/yarp.rb
@@ -95,7 +95,7 @@ def start_column
     # The column number in bytes where this location ends from the start of the
     # line.
     def end_column
-      source.column(end_offset - 1)
+      source.column(end_offset)
     end
 
     def deconstruct_keys(keys)

diff --git a/test/yarp/location_test.rb b/test/yarp/location_test.rb
@@ -817,6 +817,14 @@ def assert_location(kind, source, expected = 0...source.length)
       node = result.value.statements.body.last
       node = yield node if block_given?
 
+      if expected.begin == 0
+        assert_equal 0, node.location.start_column
+      end
+
+      if expected.end == source.length
+        assert_equal source.split("\n").last.length, node.location.end_column
+      end
+
       assert_kind_of kind, node
       assert_equal expected.begin, node.location.start_offset
       assert_equal expected.end, node.location.end_offset