test/openssl/test_pkey_ec.rb: refactor tests for EC.builtin_curves

[rhenium]

Check that OpenSSL::PKey::EC.builtin_curves returns an array in the expected format.

Similarly to OpenSSL::Cipher.ciphers, OpenSSL::PKey::EC.builtin_curves returns a list of known named curves rather than actually usable ones.

#671 found that the list may include unapproved (and thus unusable) curves when the FIPS module is loaded.

[junaruga]

Thanks for the PR. I tested the PR on my local in FIPS case. And I can see the test_ec_key and newly added test_builtin_curves pass in the case. The failure of the test_ECPrivateKey_encrypted is not related to this PR.

$ OPENSSL_CONF=/home/jaruga/.local/openssl-3.2.0-dev-fips-debug-cf712830b7/ssl/openssl_fips.cnf \
  bundle exec ruby -I./lib -ropenssl test/openssl/test_pkey_ec.rb
Loaded suite test/openssl/test_pkey_ec
Started
E
===================================================================================================================================================================================================================
Error: test_ECPrivateKey_encrypted(OpenSSL::TestEC): OpenSSL::PKey::ECError: invalid curve name
test/openssl/test_pkey_ec.rb:244:in `initialize'
test/openssl/test_pkey_ec.rb:244:in `new'
test/openssl/test_pkey_ec.rb:244:in `test_ECPrivateKey_encrypted'
     241:     0/dGSU5SzFG+iT9iFXCwCvv+bxyegkBOyALFje1NAsM=
     242:     -----END EC PRIVATE KEY-----
     243:     EOF
  => 244:     key = OpenSSL::PKey::EC.new(pem, "abcdef")
     245:     assert_same_ec p256, key
     246:     key = OpenSSL::PKey::EC.new(pem) { "abcdef" }
     247:     assert_same_ec p256, key
===================================================================================================================================================================================================================
Finished in 0.04712535 seconds.
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
17 tests, 130 assertions, 0 failures, 1 errors, 0 pendings, 0 omissions, 0 notifications
94.1176% passed
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
360.74 tests/s, 2758.60 assertions/s

[rhenium]

Thanks for the confirmation!

BTW, please press the merge button whenever the changes look good to merge.

[junaruga]

BTW, please press the merge button whenever the changes look good to merge.

All right. I will keep it in mind, and will do it next time.