Use openssl? instead of OpenSSL::OPENSSL_VERSION_NUMBER. #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junaruga
force-pushed
the
wip/test-use-openssl-version-method
branch
from
05bfef6
to
a237e44
Compare
Update the `openssl?` method by adding status argument. Note the format is below. * OpenSSL 3: 0xMNN00PP0 (major minor 00 patch 0) * OpenSSL 1: 0xMNNFFPPS (major minor fix patch status) See <https://www.openssl.org/docs/man1.1.1/man3/OPENSSL_VERSION_NUMBER.html> for details.
junaruga
force-pushed
the
wip/test-use-openssl-version-method
branch
from
a237e44
to
db8deaa
Compare
|
I am rebasing updating the code and commit message. I updated the Note the format is below.
You can see the following documents for details, and other versions of the documents from the links on the page. |
|
Yes, these should have been using the |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is just for refactoring to use the common method
test/openssl/utils.rb#openssl?instead of using theOpenSSL::OPENSSL_VERSION_NUMBERdirectly.