Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the latest version of EnvUtil #593

Merged
merged 3 commits into from
Jan 4, 2023
Merged

Update the latest version of EnvUtil #593

merged 3 commits into from
Jan 4, 2023

Conversation

hsbt
Copy link
Member

@hsbt hsbt commented Jan 4, 2023

Resolve #589

envutil.rb in this repository is pretty old. I update it with the latest version of ruby/ruby repository.

@eregon
Copy link
Member

eregon commented Jan 4, 2023

This new version seems to have the same problem as the old one did on TruffleRuby:
From https://github.com/ruby/openssl/actions/runs/3837266200/jobs/6532377487 but this happens even on CRuby 3.0:

===============================================================================
Error: test_openssl_engine_id_name_inspect(OpenSSL::TestEngine):
  Timeout::Error: execution of assert_separately expired timeout (10 sec)
  pid 6324 killed by SIGKILL (signal 9)
  | 
  | /home/runner/work/openssl/openssl/test/openssl/test_engine.rb:77: warning: Skipping set of ruby2_keywords flag for with_openssl (method accepts keywords or method does not accept argument splat)
-------------------------------------------------------------------------------
0 tests, 1 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
0% passed
-------------------------------------------------------------------------------
0.00 tests/s, 0.02 assertions/s
5 tests, 6 assertions, 0 failures, 5 errors, 0 pendings, 0 omissions, 0 notifications
Finished in 59.363426555 seconds.
-------------------------------------------------------------------------------
6 tests, 6 assertions, 0 failures, 6 errors, 0 pendings, 0 omissions, 0 notifications
-------------------------------------------------------------------------------
0 tests, 1 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
0% passed
-------------------------------------------------------------------------------
0.00 tests/s, 0.03 assertions/s

0% passed
-------------------------------------------------------------------------------
0.06 tests/s, 0.09 assertions/s
Finished in 51.416196363 seconds.

-------------------------------------------------------------------------------
0% passed
-------------------------------------------------------------------------------
0.07 tests/s, 0.09 assertions/s
Finished in 26.780028326 seconds.
-------------------------------------------------------------------------------
1 tests, 2 assertions, 0 failures, 1 errors, 0 pendings, 0 omissions, 0 notifications
0% passed
-------------------------------------------------------------------------------

@eregon
Copy link
Member

eregon commented Jan 4, 2023

https://github.com/ruby/openssl/pull/593/files#diff-e3677884066a26b36e5b40dec61618ca2e3de14232a1468e9989696b7ffdcbf3R251 does Test::Unit::Runner.class_variable_set(:@@stop_auto_run, true) if defined?(Test::Unit::Runner) which doesn't seem correct with recent test-unit.

@hsbt
Copy link
Member Author

hsbt commented Jan 4, 2023

We can remove L251 and L263. But I'm not sure why tests failed with < Ruby 3.1.

@hsbt
Copy link
Member Author

hsbt commented Jan 4, 2023

@eregon Thanks. I understood #589 and oracle/truffleruby#2800.

Copy link
Member

@eregon eregon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@eregon eregon requested a review from rhenium January 4, 2023 15:12
Copy link
Member

@rhenium rhenium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you!

@rhenium rhenium merged commit 79aa330 into master Jan 4, 2023
@rhenium rhenium deleted the update-envutil branch January 4, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants