Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOC] RDoc for Open3 #18

Merged
merged 6 commits into from
Nov 10, 2023
Merged

[DOC] RDoc for Open3 #18

merged 6 commits into from
Nov 10, 2023

Conversation

BurdetteLamar
Copy link
Member

Will need examples, and perhaps more text. But first: is this text correct?

@BurdetteLamar BurdetteLamar marked this pull request as draft October 25, 2023 19:08
@BurdetteLamar BurdetteLamar added the documentation Improvements or additions to documentation label Oct 25, 2023
peterzhu2118
peterzhu2118 reviewed Oct 25, 2023
View reviewed changes
lib/open3.rb Outdated Show resolved Hide resolved
lib/open3.rb Outdated Show resolved Hide resolved
BurdetteLamar and others added 2 commits November 5, 2023 09:27
@BurdetteLamar @peterzhu2118
Update lib/open3.rb
06e4702 
Co-authored-by: Peter Zhu <peter@peterzhu.ca>
@BurdetteLamar @peterzhu2118
Update lib/open3.rb
05bff9d 
Co-authored-by: Peter Zhu <peter@peterzhu.ca>
peterzhu2118
peterzhu2118 approved these changes Nov 5, 2023
View reviewed changes
Copy link
Member

@peterzhu2118 peterzhu2118 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good. Is there anything you want to address before changing it to a non-draft PR?

@BurdetteLamar
Copy link
Member Author

I think it looks good. Is there anything you want to address before changing it to a non-draft PR?

Yes. I think the present discussion can be improved (under way) and code examples are needed.

@BurdetteLamar
Copy link
Member Author

@peterzhu2118, ready to merge. Do the honors?

@peterzhu2118 peterzhu2118 marked this pull request as ready for review November 10, 2023 17:14
@peterzhu2118 peterzhu2118 merged commit 9f3f5d0 into ruby:master Nov 10, 2023
21 checks passed
matzbot pushed a commit to ruby/ruby that referenced this pull request Nov 10, 2023
@BurdetteLamar @matzbot
[ruby/open3] [DOC] RDoc for Open3
82ce474 
(ruby/open3#18)

ruby/open3@9f3f5d004c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterzhu2118 peterzhu2118 peterzhu2118 approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BurdetteLamar @peterzhu2118