-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ability to use Grape::Entity documentation in the params block #560
Conversation
validates(attrs, validations) | ||
opts = attrs.last.is_a?(Hash) ? attrs.pop : nil | ||
if opts && opts[:using] | ||
if attrs.first == :all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is getting a bit dense. Maybe try to refactor this into a function or two? Same for the else
block.
This looks very good. Also need a CHANGELOG update, please. Thx. |
Cool, changes done :) |
I created a new pull request (can't change repo/branch a pull request): |
Sorry for the delay finishing the test. It should be ready to merge now. |
Thanks! Merged via f5d7306. Can you please double-check it, I rewrote the README section to be a bit simpler. |
Thanks! |
Check master. If anything is missing, sorry about that, and please make another PR. |
Def |
The `requires` statement should be in a `params` block according to ruby-grape#560.
Is |
Yes. |
You can use entity documentation in the params block