Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optional groups #443

Merged
merged 10 commits into from
Aug 6, 2013
Merged

Optional groups #443

merged 10 commits into from
Aug 6, 2013

Commits on Jul 19, 2013

  1. specs for issue ruby-grape#319 (optional groups)

    @asross
    asross committed Jul 19, 2013
    Configuration menu
    Copy the full SHA
    841f76d View commit details
    Browse the repository at this point in the history

  2. possible implementation for ruby-grape#319 

    Might be better to go with `optional_group(element)` than `group(element, required: false)`?
    @asross
    asross committed Jul 19, 2013
    Configuration menu
    Copy the full SHA
    85bfdc2 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2013

  1. refactor

    @asross
    asross committed Jul 20, 2013
    Configuration menu
    Copy the full SHA
    b2edec9 View commit details
    Browse the repository at this point in the history

  2. use optional_group(e) rather than group(e, optional: true) 

    feels a little clearer.
    @asross
    asross committed Jul 20, 2013
    Configuration menu
    Copy the full SHA
    ce81c79 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2013

  1. update CHANGELOG and README

    @asross
    asross committed Jul 22, 2013
    Configuration menu
    Copy the full SHA
    5915e9a View commit details
    Browse the repository at this point in the history

  2. initialize ParamsScope with a hash of options

    @asross
    asross committed Jul 22, 2013
    Configuration menu
    Copy the full SHA
    8652c92 View commit details
    Browse the repository at this point in the history

  3. remove ParamsScope#optional_group, and instead allow #requires and #o… 

    …ptional to take blocks
    @asross
    asross committed Jul 22, 2013
    Configuration menu
    Copy the full SHA
    e70c3ce View commit details
    Browse the repository at this point in the history

  4. update CHANGELOG and README

    @asross
    asross committed Jul 22, 2013
    Configuration menu
    Copy the full SHA
    da5d187 View commit details
    Browse the repository at this point in the history

  5. Merge intridea:master

    @asross
    asross committed Jul 22, 2013
    Configuration menu
    Copy the full SHA
    ac72a48 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2013

  1. slight refactor

    @asross
    asross committed Jul 23, 2013
    Configuration menu
    Copy the full SHA
    01f3b81 View commit details
    Browse the repository at this point in the history