Merge pull request #239 from ruby-formatter/ignore-node-modules

Ignore node modules folder
ruby-formatter · Mar 8, 2020 · fe88a0b · fe88a0b
2 parents 0e25646 + 924e198
commit fe88a0b
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -15,6 +15,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 ### Added
 - Code coverage tracking with codecov.io
+- `node_modules` folders are now ignored.
 
 ## [0.11.0] - 2020-02-09
 

diff --git a/lib/rufo/file_finder.rb b/lib/rufo/file_finder.rb
@@ -28,12 +28,9 @@ class Rufo::FileFinder
     *EXTENSIONS,
   ]
 
-  EXCLUDED_DIRS = [
-    "vendor",
-  ]
-
   EXCLUDE_PATTERNS = [
     "vendor/**/*",
+    "node_modules/**/*",
   ]
 
   def initialize(files_or_dirs, includes: [], excludes: [])

diff --git a/...tures/file_finder/only_vendor/vendor/a.rb → ...ile_finder/dependency_folders/vendor/a.rb b/...tures/file_finder/only_vendor/vendor/a.rb → ...ile_finder/dependency_folders/vendor/a.rb
diff --git a/spec/lib/rufo/file_finder_spec.rb b/spec/lib/rufo/file_finder_spec.rb
@@ -51,10 +51,10 @@
     end
   end
 
-  context "the directory contains vendor directory" do
-    let(:file_or_dir) { finder_fixture_path("only_vendor") }
+  context "the directory contains common dependency directories" do
+    let(:file_or_dir) { finder_fixture_path("dependency_folders") }
 
-    it "ignores the vendor directory" do
+    it "ignores the directories" do
       expect(subject.to_a).to match_array(abs_paths([]))
     end
   end