Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publishing: Only push antora.yml if it's changed #1864

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

bquorning
Copy link
Collaborator

@bquorning bquorning commented Apr 4, 2024

We don't change docs/antora.yml file on patch releases.

This does not fix the issue with git push mentioned at #1829 (comment)


Before submitting the PR make sure the following are checked:

  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Updated documentation.
  • Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
  • The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

We don't change the file on patch releases.
@bquorning bquorning marked this pull request as ready for review April 5, 2024 06:21
@bquorning bquorning requested a review from a team as a code owner April 5, 2024 06:21
Copy link
Member

@ydah ydah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lools good! Thank you.

@ydah ydah merged commit 536c9c3 into master Apr 5, 2024
24 checks passed
@ydah ydah deleted the improve-publish-workflow branch April 5, 2024 06:50
ydah added a commit to rubocop/rubocop-capybara that referenced this pull request Apr 8, 2024
ydah added a commit to rubocop/rubocop-factory_bot that referenced this pull request Apr 8, 2024
ydah added a commit to rubocop/rubocop-rspec_rails that referenced this pull request Apr 8, 2024
ydah added a commit to rubocop/rubocop-capybara that referenced this pull request Apr 10, 2024
ydah added a commit to rubocop/rubocop-factory_bot that referenced this pull request Apr 10, 2024
ydah added a commit to rubocop/rubocop-rspec_rails that referenced this pull request Apr 10, 2024
ydah added a commit to rubocop/rubocop-capybara that referenced this pull request Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants