Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Rubygems Trusted Publishers to publish #111

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Conversation

ydah
Copy link
Member

@ydah ydah commented Apr 8, 2024

Follow up:

Note that this requires the following settings to be checked on:


Before submitting the PR make sure the following are checked:

  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • [-] Added tests.
  • [-] Updated documentation.
  • [-] Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
  • The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

@ydah ydah requested a review from a team as a code owner April 8, 2024 13:18
Copy link
Contributor

@bquorning bquorning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we’ll need to fix rubocop/rubocop-rspec#1865 first.

@ydah ydah merged commit 901c425 into master Apr 10, 2024
25 checks passed
@ydah ydah deleted the trusted-publishing branch April 10, 2024 05:37
@bquorning
Copy link
Contributor

I checked, and changed the settings (“Read and write permissions” were selected before)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants