Merge pull request #1370 from fatkodima/select_map-safe-navigation

Change `Rails/SelectMap` to handle safe navigation operators

changelog/change_select_map_safe_navigation_handle_safe_navigation.md

@@ -0,0 +1 @@
+* [#1195](https://github.com/rubocop/rubocop-rails/issues/1195): Change `Rails/SelectMap` to handle safe navigation operators. ([@fatkodima][])

lib/rubocop/cop/rails/select_map.rb

@@ -40,12 +40,13 @@ def on_send(node)
             autocorrect(corrector, select_node, node, preferred_method)
           end
         end
+        alias on_csend on_send
 
         private
 
         def find_select_node(node, column_name)
           node.descendants.detect do |select_candidate|
-            next if !select_candidate.send_type? || !select_candidate.method?(:select)
+            next if !select_candidate.call_type? || !select_candidate.method?(:select)
 
             match_column_name?(select_candidate, column_name)
           end

spec/rubocop/cop/rails/select_map_spec.rb

@@ -56,6 +56,17 @@
     RUBY
   end
 
+  it 'handles safe navigation chain' do
+    expect_offense(<<~RUBY)
+      relation&.select(:column_name)&.map(&:column_name)
+                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Use `pluck(:column_name)` instead of `select` with `map`.
+    RUBY
+
+    expect_correction(<<~RUBY)
+      relation&.pluck(:column_name)
+    RUBY
+  end
+
   it 'does not register an offense when using `select(:mismatch_column_name).map(&:column_name)`' do
     expect_no_offenses(<<~RUBY)
       Model.select(:mismatch_column_name).map(&:column_name)