Add per-file output to --check and add -q flag #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will show which files would have been formatted when running with --check. The old behaviour can be restored by using --check --quiet.
JaapJoris
reviewed
Mar 4, 2023
The `--quiet` option has been removed before in favor of printing all output to stderr. That way, the user can redirect stderr to `/dev/null` in order to ignore it.
JaapJoris
approved these changes
Mar 4, 2023
|
Thank you very much for this PR. I understand the need to know which files would have been reindented, and it is also more consistent with the output without the However, I've taken the liberty to re-remove the |
|
Ah right, I didn't know that, and don't have any need for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will show which files would have been formatted when running with --check. The old behaviour can be restored by using --check --quiet.
I need this for CI, where it's usually desirable to have both the non-zero exit code and actionable and informative feedback.
The
--quietflag makes it possible to restore the original quiet behaviour with--check --quiet, and may also be nice for people who want a quiet option without--check.