Remove -i and -o command line options
#71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main use case of DjHTML is to modify files in-place. Therefore, the `-i`
(`--in-place`) argument has been made the default and removed, leaving only
a deprecation error. The `-o` (`--output-file`) argument has also been
removed.
Reading from standard input and writing to standard output is still
supported by using "-" as the filename. By the same mechanism, writing the
output to a different file is also still possible by using output
redirection:
djhtml - < input.html > output.html
Since this is a backwards-incompatible change, the next release will
increment the major version number. No changes have been made to the
indentation algorithm.
Closes #66
Closes #69
Closes #70
JaapJoris
commented
Jan 30, 2023
JaapJoris
commented
Jan 30, 2023
JaapJoris
commented
Jan 30, 2023
JaapJoris
commented
Jan 30, 2023
JaapJoris
commented
Jan 30, 2023
JaapJoris
commented
Jan 31, 2023
sjoerdjob
reviewed
Jan 31, 2023
sjoerdjob
reviewed
Jan 31, 2023
JaapJoris
force-pushed
the
69-funny-behavior-with-pre-commit-and-windows
branch
from
88184d6
to
1cdafb3
Compare
JaapJoris
force-pushed
the
69-funny-behavior-with-pre-commit-and-windows
branch
from
11adaa2
to
2fc2413
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
-iand-ocommand line options have been removed, and the argument parsing has been moved to a separateoptionsmodule. Finally, a small bug (#70) has been fixed as well.