Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong indention of multi-line @font-face declaration #74

Closed
GitRon opened this issue Feb 7, 2023 · 3 comments · Fixed by #77
Closed

Wrong indention of multi-line @font-face declaration #74

GitRon opened this issue Feb 7, 2023 · 3 comments · Fixed by #77

Comments

@GitRon
Copy link

GitRon commented Feb 7, 2023

Hi @JaapJoris

I am truely sorry for raising that many issues 😅 I just saw this odd behaviour... I guess this is not intended, is it? (the right side is after the reformatting)

grafik

Thx!
Ronny
@JaapJoris
Copy link
Member

Please don't apologize, and thank you for discovering another bug! This is definitely not the correct behavior, and I will see what I can do to fix it.

@JaapJoris JaapJoris self-assigned this Feb 7, 2023
@JaapJoris JaapJoris mentioned this issue Feb 10, 2023
Closed
JaapJoris added a commit that referenced this issue Feb 13, 2023
@JaapJoris
DjHTML Version 3
f5c7de3 
For this release, a substantial part the codebase has been refactored.
Here is a non-exhaustive summary of all the things that have changed:

- Support for Python 3.6 and 3.7 has been dropped
- A Django middleware class to indent HTML responses has been added
- Ignore both opening and closing comment tags
- New handling off both relative and absolute offsets
- Return correct `repr()` strings with the `--debug` option
- New token class "OpenDouble" and a revised indentation algorithm
- Additional `line` argument to `create_token()` methods
- Changed return value of `create_token()` methods
- Changed constructor arguments of Token and Line classes
- Refactored all `create_token()` methods to get rid of return statements
- Simplified test suite runner that reindents the expected output
- Don't indent the contents of template variables (closes #75)
- Improved handling of Django tags inside HTML elements
- Improved JavaScript `case` indentation (closes #76)
- Improved JavaScript method chaining (closes #59)
- Improved CSS multiline statements (closes #74)
- New multiline HTML element indentation (closes #50)
- New multiline HTML attribute value indentation
- Extensive test coverage with lots of edge cases
@JaapJoris JaapJoris mentioned this issue Feb 13, 2023
Merged
JaapJoris added a commit that referenced this issue Feb 13, 2023
@JaapJoris
DjHTML Version 3
4ccab3b 
For this release, a substantial part the codebase has been refactored.
Here is a non-exhaustive summary of all the things that have changed:

- Support for Python 3.6 and 3.7 has been dropped
- A Django middleware class to indent HTML responses has been added
- Ignore both opening and closing comment tags
- New handling off both relative and absolute offsets
- Return correct `repr()` strings with the `--debug` option
- New token class "OpenDouble" and a revised indentation algorithm
- Additional `line` argument to `create_token()` methods
- Changed return value of `create_token()` methods
- Changed constructor arguments of Token and Line classes
- Refactored all `create_token()` methods to get rid of return statements
- Simplified test suite runner that reindents the expected output
- Don't indent the contents of template variables (closes #75)
- Improved handling of Django tags inside HTML elements
- Improved JavaScript `case` indentation (closes #76)
- Improved JavaScript method chaining (closes #59)
- Improved CSS multiline statements (closes #74)
- New multiline HTML element indentation (closes #50)
- New multiline HTML attribute value indentation
- Extensive test coverage with lots of edge cases
JaapJoris added a commit that referenced this issue Feb 13, 2023
@JaapJoris
DjHTML Version 3
ae01cb6 
For this release, a substantial part the codebase has been refactored.
Here is a non-exhaustive summary of all the things that have changed:

- Support for Python 3.6 and 3.7 has been dropped
- A Django middleware class to indent HTML responses has been added
- Ignore both opening and closing comment tags
- New handling off both relative and absolute offsets
- Return correct `repr()` strings with the `--debug` option
- New token class "OpenDouble" and a revised indentation algorithm
- Additional `line` argument to `create_token()` methods
- Changed return value of `create_token()` methods
- Changed constructor arguments of Token and Line classes
- Refactored all `create_token()` methods to get rid of return statements
- Simplified test suite runner that reindents the expected output
- Don't indent the contents of template variables (closes #75)
- Improved handling of Django tags inside HTML elements
- Improved JavaScript `case` indentation (closes #76)
- Improved JavaScript method chaining (closes #59)
- Improved CSS multiline statements (closes #74)
- New multiline HTML element indentation (closes #50)
- New multiline HTML attribute value indentation
- Extensive test coverage with lots of edge cases
@jacklinke jacklinke mentioned this issue Feb 16, 2023
Closed
@JaapJoris JaapJoris removed their assignment Feb 21, 2023
@JaapJoris
Copy link
Member

JaapJoris commented Feb 23, 2023 •
edited
Loading

Thanks again for your contribution! DjHTML 3.0.0 has just been released and fully supports multi-line variable assignments, including many edge cases covered by unittests.

@GitRon
Copy link
Author

GitRon commented Feb 23, 2023

Awesome! Thx alot! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

DjHTML Version 3 rtts/djhtml
2 participants
@GitRon @JaapJoris