Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: 兼容rsuite@5 Modal #14

Merged
merged 8 commits into from
Mar 22, 2021
Merged

update: 兼容rsuite@5 Modal #14

merged 8 commits into from
Mar 22, 2021

Conversation

MarvelSQ
Copy link
Member

@MarvelSQ MarvelSQ commented Jan 7, 2021

Modal show 改为 open

@SevenOutman
Copy link
Member

暂时不要移除 rsuite@4 的支持

@MarvelSQ
Copy link
Member Author

MarvelSQ commented Jan 9, 2021

暂时不要移除 rsuite@4 的支持

通过proptypes判断rsuite版本

@SevenOutman
Copy link
Member

CI 没通过。把这块的测试补一下吧,验证分别在 rsuite 3/4 和 rsuite 5 上可以正常运行。

@MarvelSQ
Copy link
Member Author

MarvelSQ commented Mar 3, 2021

CI 没通过。把这块的测试补一下吧,验证分别在 rsuite 3/4 和 rsuite 5 上可以正常运行。

测试用例已修复
v3的兼容性已修复

v3/v4/v5-alpha都已测试正常运行

@SevenOutman SevenOutman merged commit 3a47102 into rsuite:master Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants