Build TinyTex-2 on windows as self extracting archive using sfx #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aim is to have a self extracting archive which will be more compressed than previous zip
fixup: correct variable in BAT
yihui
reviewed
Jan 11, 2023
| @@ -487,7 +493,7 @@ download_installer = function(file, version) { | |||
| url = if (version != '') sprintf( | |||
| 'https://github.com/rstudio/tinytex-releases/releases/download/v%s/%s', version, file | |||
| ) else paste0(getOption('tinytex.install.url', 'https://yihui.org/tinytex/'), file) | |||
| download_file(url, file) | |||
| download_file(url, file, mode = if (is_windows()) "wb" else "w") | |||
There was a problem hiding this comment.
I think we can just use mode = 'wb' for all platforms, not only Windows. We know for sure that all these files are binary instead of text.
There was a problem hiding this comment.
I did that at first, but was not sure if mode = "wb" was supported or useful on all platform.
As you are confirming it is a thing on non-windows too, I'll modify then !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aim is to have a self extracting archive which will be more compressed than previous zip as we are close to limit already
closes #396