Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What about exported is_tinytex and check_installed ? #269

Closed
cderv opened this issue Jan 21, 2021 · 7 comments
Closed

What about exported is_tinytex and check_installed ? #269

cderv opened this issue Jan 21, 2021 · 7 comments

Comments

@cderv
Copy link
Contributor

cderv commented Jan 21, 2021

We advice to use them : rstudio/rticles#364 (comment)

and I often use "revtex4-1" %in% tinytex::tl_pkgs() to check what I could do with tinytex:::check_installed("revtex4-1")

So why not ?

@yihui
Copy link
Member

yihui commented Jan 21, 2021

I was just too lazy to document them :) For is_tinytex(), it is also a little hackish:

any(grepl(
    '\\W[.]?TinyTeX\\W',
    readLines(file.path(root, 'texmf-dist/web2c/fmtutil.cnf'), n = 1)
))

I guess it should work for 99.999% of cases, though.

Anyway, I'll export and document them.

@cderv
Copy link
Contributor Author

cderv commented Jan 21, 2021

I can also do it :)

I open issue here mainly to share ideas with you, but feel free to say ok, then assign me 😄
Especially for those were lazyness win 😉

BTW check_installed is the most useful.

@yihui
Copy link
Member

yihui commented Jan 21, 2021

It's only a 10-min task, so I'm happy to do it. I have more boring tasks that I feel definitely too lazy to do. For example, I have been hoping to change the test syntax from assert(cond1, cond2) to assert({ (cond1); (cond2) }) in all packages. You may start with knitr: https://github.com/yihui/knitr/tree/master/tests/testit

@cderv
Copy link
Contributor Author

cderv commented Jan 21, 2021

Ok ! I can do that on the long run. :)

@yihui yihui closed this as completed in 149f7e7 Jan 21, 2021
@yihui
Copy link
Member

yihui commented Jan 21, 2021

When you feel tired, you may do that, since it doesn't require much brain power :)

The two functions have been documented and exported now.

@cderv
Copy link
Contributor Author

cderv commented Jan 21, 2021

I did that then in rticles rstudio/rticles@90795a4

Is it ok ?

@yihui
Copy link
Member

yihui commented Jan 21, 2021

Yes.

clrpackages pushed a commit to clearlinux-pkgs/R-xfun that referenced this issue Feb 16, 2021
Christophe Dervieux (1):
      Add an argument to pass options flag to Rscript_call() (#48)

Yihui Xie (13):
      start the next version
      .org -> .io
      make `verbose` an explicit argument of bg_process()
      close #45: add a new function `pkg_available()` to test if a package with a minimal version is available
      mention pacman::p_load(), which came much earlier than xfun::pkg_attach2()
      add a utility function to update a single package
      get rid of an unused variable
      add a new function set_envvar()
      add a new function `exit_call()` to call a function when a parent function exits
      document and export read_bin()
      add an example to read_bin()
      is_tinytex() will be exported in the next version of tinytex: rstudio/tinytex#269
      CRAN release v0.21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants