Refactoring to reduce dplyr usage and speed up locale resolution #1851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olivroy
commented
Aug 21, 2024
| @@ -323,8 +323,8 @@ test_that(" from_column() works correctly", { | |||
| c( | |||
| "+1.11 $\\times$ 10\\textsuperscript{+4}", "+4.44 $\\times$ 10\\textsuperscript{+5}", | |||
| "+1.00 $\\times$ 10\\textsuperscript{+7}", "+1.78 $\\times$ 10\\textsuperscript{+8}", | |||
| "2.78 $\\times$ 10\\textsuperscript{9}", "NA", "5.44 $\\times$ 10\\textsuperscript{11}", | |||
| "7.10 $\\times$ 10\\textsuperscript{12}" | |||
| "2.77 $\\times$ 10\\textsuperscript{9}", "NA", # previously 2.78 | |||
There was a problem hiding this comment.
I just upgraded to R 4.4.1 and got a test failure here. However, it seems like a consistent change, the test below reports 2.77, not 2.78.. We'll see what CI has to say!
olivroy
commented
Aug 21, 2024
| @@ -318,3 +318,12 @@ test_that("fmt_datetime() works correctly", { | |||
| ) | |||
| ) | |||
| }) | |||
|
|
|||
| test_that("A gt table will properly output a date to LaTeX out of the box", { | |||
| skip() | |||
There was a problem hiding this comment.
I attempted to fix an issue where a date would show badly as LaTeX, but I didn't figure it out. So added a test in the meantime.
as_latex(tab %>% fmt_date(date)) works.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid unnecessary tidy-eval when possible should speed things up a little